fix(#55): remove broken qualityflow agent reference - #56
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#55): remove broken qualityflow agent reference#56fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Remove the qualityflow agent entry and its allowed_remote_resources entry from .fullsend/config.yaml. The pinned commit (b26c947) in redhat-community-ai-tools/qualityflow-fullsend predates the addition of qualityflow/agents/qualityflow.md, causing a 404 on every agent run. This was confirmed across three CI runs on PR #54. Removing the reference eliminates the log noise. The reference can be re-added with a valid commit SHA if qualityflow is needed in the future. Note: pre-commit could not run in sandbox (network policy blocked hook installation). YAML validity confirmed via Python yaml.safe_load. Closes #55
|
🤖 Finished Review · ✅ Success · Started 7:16 PM UTC · Completed 7:27 PM UTC Commit: |
|
Looks good to me |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qualityflowagent entry from.fullsend/config.yaml— the pinned commit (b26c947) predates the addition of the agent definition file, causing a 404 on every agent runallowed_remote_resourcesentry, which existed solely for the qualityflow referenceskipping agent qualityflow: load failedlog noise observed across all three review runs on PR chore: remove pinned agent digests, rely on CLI fallback #54Context
The
qualityflow.yamlharness at the pinned commit referencesqualityflow/agents/qualityflow.md, but that file does not exist at commitb26c947inredhat-community-ai-tools/qualityflow-fullsend. The triage agent confirmed the pinned commit predates the addition of agent definitions to that repo. The reference can be re-added with a valid commit SHA if qualityflow integration is needed in the future.Test plan
skipping agent qualityflow: load failedwith a 404 status.fullsend/config.yamlparses as valid YAML (verified locally viayaml.safe_load)Closes #55
Post-script verification
agent/55-fix-qualityflow-ref)83701484737a85d7e9fc6e741225fa991cad8eb7..HEAD)